Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show progressbar only on progress_rank 0 on ddp_slurm #4437

Merged
merged 4 commits into from
Nov 6, 2020
Merged

show progressbar only on progress_rank 0 on ddp_slurm #4437

merged 4 commits into from
Nov 6, 2020

Conversation

cool425589
Copy link
Contributor

@cool425589 cool425589 commented Oct 30, 2020 •
edited
Loading

What does this PR do?

#4364
When submit the SLURM job with accelerator=ddp setting, It will show progressbar on all progress_rank except progress_rank 0. For now show progressbar only on progress_rank 0

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added bug Something isn't working distributed Generic distributed-related topic labels Oct 30, 2020
@awaelchli awaelchli added this to the 1.0.x milestone Oct 30, 2020
@codecov
Copy link

codecov bot commented Oct 30, 2020 •
edited
Loading

Codecov Report

Merging #4437 into master will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4437   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         116     116           
  Lines        8815    8815           
======================================
- Hits         8228    8217   -11     
- Misses        587     598   +11

tchaton
tchaton approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch ! Thanks for your contributions.

@awaelchli awaelchli merged commit 5e09fd3 into Lightning-AI:master Nov 6, 2020
@Limtle Limtle mentioned this pull request Nov 10, 2020
Closed
SeanNaren pushed a commit that referenced this pull request Nov 10, 2020
@cool425589
show progressbar only on progress_rank 0 on ddp_slurm (#4437)
55ab025 
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
(cherry picked from commit 5e09fd3)
rohitgr7 pushed a commit that referenced this pull request Nov 21, 2020
@cool425589 @tchaton
@awaelchli @rohitgr7
show progressbar only on progress_rank 0 on ddp_slurm (#4437)
290998d 
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@justusschock justusschock justusschock approved these changes

@tchaton tchaton tchaton approved these changes

@awaelchli awaelchli awaelchli approved these changes

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@nateraw nateraw Awaiting requested review from nateraw

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@teddykoker teddykoker Awaiting requested review from teddykoker

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
bug Something isn't working distributed Generic distributed-related topic environment: slurm
Projects
None yet
Milestone
pl:1.0.x
Development

Successfully merging this pull request may close these issues.
6 participants
@cool425589 @awaelchli @tchaton @justusschock @SkafteNicki @Borda